Repository navigation
fix(library-server): highlights import and sync fail on Postgres (JSON parameter sent as a string) - #46
Merged
Conversation
…xt (postgres.js sent them as a JSON string); tests and CI on a real Postgres The import failed in production with "cannot call jsonb_to_recordset on a non-array": for a $n::jsonb parameter postgres.js encodes the JSON text again, so Postgres got a JSON string instead of the array. Casting through text ($n::text::jsonb) sends it as it is. PGlite, which the tests used, passes it unchanged, so they did not show it: TEST_POSTGRES_URL runs them on a real Postgres (14 of 16 fail there without this fix), and CI does so with a Postgres service. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Codex review — round 1 (fast) (Codex CLI's output, posted here via STATUS: LGTM It also checked the other array parameters ( |
sawradip
added a commit
that referenced
this pull request
Nov 1, 2026
Deploy the library server: highlights import and sync on Postgres (#46)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke: the first
highlights:move --gointo the production library (deployed with #44 via #45) failed withcannot call jsonb_to_recordset on a non-array, and the server answered 500. Nothing was written: each request is one transaction, and the library still has no lines or links.Why: for a
$n::jsonbparameter, postgres.js (the production driver) encodes the JSON text again, so Postgres received a JSON string instead of the array. PGlite, which the tests used, passes the text through unchanged, so the tests did not catch it. This affectslines/syncandimport, the two routes that send many rows at once.Fix:
jsonb_to_recordset($2::jsonb)becomejsonb_to_recordset($2::text::jsonb).highlights.test.tsalso runs on a real Postgres whenTEST_POSTGRES_URLis set.Checked:
pnpm checkpasses.After merging, a release PR into
proddeploys it.🤖 Generated with Claude Code