Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/optimize-module-scaffolding.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@runablejs/cli": minor
"runable": patch
---

Generate modules as minimal publishable workspace packages with a complete framework playground. Include local module configuration files in the generated TypeScript project and let the welcome screen fill its container without the browser's default body gap.
6 changes: 1 addition & 5 deletions packages/cli/src/commands/create/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,7 @@ export async function createModulePlayground(
packageJson.name = `${options.moduleName.replace(/^@/, "").replace("/", "-")}-playground`;
packageJson.private = true;
packageJson.scripts = packageJson.scripts ?? {};
packageJson.scripts.prepare = "runable prepare";
delete packageJson.scripts.preprepare;
delete packageJson.scripts.prebuild;
delete packageJson.scripts["app:prepare"];
delete packageJson.scripts["app:build"];
packageJson.scripts.prepare ??= "runable prepare";
await writeFile(packageJsonPath, `${JSON.stringify(packageJson, null, 2)}\n`);

await writeFile(
Expand Down
25 changes: 25 additions & 0 deletions tests/regressions/cli-create-module.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,29 @@ describe("runable create --module", () => {
cleanupFixtureDir(directory);
}
});

it("preserves framework-specific playground lifecycle scripts", async () => {
const directory = createFixtureDir("cli-module-adonis-playground-");

try {
const { createModulePlayground } = await import(
"../../packages/cli/dist/commands/create/module.js"
);
await createModulePlayground(directory, {
moduleName: "test-module",
framework: "adonisjs",
});

const packageJson = JSON.parse(
readFileSync(
path.join(directory, "playground/package.json"),
"utf8",
),
);
expect(packageJson.scripts.prepare).toBe("node ace generate:manifest");
expect(packageJson.scripts.preprepare).toBe("runable prepare");
} finally {
cleanupFixtureDir(directory);
}
});
});
Loading