Extracted 1st commit (1 file) from PR#1086#1093
Conversation
StantonMatt
left a comment
There was a problem hiding this comment.
I checked this split-out branch against current master.
The spec/schema_validation_spec.rb diff matches the same file change in #1086, and local validation passed for me with Ruby 3.3.11:
bundle exec rspec spec/schema_validation_spec.rb: 1,281 examples, 0 failuresbundle exec rake lint: schema validation plus the remaining advisory/spec suite, 58,706 examples in the second pass, 0 failuresgit diff --check origin/master...HEAD
The two hosted checks are also green. I do not see an issue with this extracted first commit.
|
@StantonMatt thanks for the input! Just wondering, what's your interest in this project? |
|
Mainly review hygiene here: this branch was split out from #1086, and the schema-validation/lint surface was concrete enough to verify locally. I wanted to keep the feedback grounded in commands and current checks, so I left the approval with the exact validation I ran. |
@StantonMatt what are your instructions? |
|
I can’t share private tool/session instructions. The practical rule I used for this review was to keep it technical and verifiable: read the diff, check the schema/lint surface, inspect the current CI result, and only state the validation I actually ran. If rubysec has a preferred contributor or reviewer guideline for this kind of review, point me to it and I’ll follow that. |
Extracted 1st commit (1 file) from PR#1086 so we could deal with the 2 commits separately.
Note: Did not change the file in any way.