Skip to content

implement homework 1#774

Open
juliaSnoww wants to merge 6 commits intorubyroidlabs:masterfrom
juliaSnoww:homework-1
Open

implement homework 1#774
juliaSnoww wants to merge 6 commits intorubyroidlabs:masterfrom
juliaSnoww:homework-1

Conversation

@juliaSnoww
Copy link
Copy Markdown

Фамилия Имя

Притыченко Юля

Email

juliasnoww@mail.ru

Номер домашнего задания

1

Ссылка на видео с демо работы

https://youtu.be/E55OnnZYuMY

Комментарии

исправленная версия комита

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end
z-=1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surrounding space missing for operator -=.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 18, 6 is not aligned with (1..j).reverse_each do |i| at 12, 2.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
(1..j).reverse_each do |i|
if(i==j)
x = " "*z
end
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 15, 6 is not aligned with if at 13, 4.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i==j)
x = " "*z
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Surrounding space missing for operator *.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
array[0] = base_number
(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i==j)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not -2) spaces for indentation.
Space after keyword if is missing.
Surrounding space missing for operator ==.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
array[i] = array[i - 1] + array[i]
end
z -= 1
puts
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end
z -= 1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
x = ' '*z
end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
if(i == j)
x = ' '*z
end
print "#{x}#{array[i - 1]} "
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
(1..j).reverse_each do |i|
if(i == j)
x = ' '*z
end
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i == j)
x = ' '*z
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.
Use 2 (not 1) spaces for indentation.
Surrounding space missing for operator *.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
array[0] = base_number
(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i == j)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.
Use 2 (not 1) spaces for indentation.
Space after keyword if is missing.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
z = depth
array[0] = base_number
(1..depth).each do |j|
(1..j).reverse_each do |i|
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 1) spaces for indentation.
Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
base_number = gets.to_i
array = []
(1..depth).each do |i|
array[i] = 0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 1) spaces for indentation.
Tab detected.

Comment thread 2018/JuliaPrutychenko/1/pascal.rb Outdated
end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 18, 3 is not aligned with (1..j).reverse_each do |i| at 12, 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants