Skip to content

faraday: Add Connection#build_url method signature #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Feb 14, 2026
+7 −0
Merged

faraday: Add Connection#build_url method signature #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gems/faraday/2.5/_test/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@
response.body
response.success?

uri = conn.build_url('/path')
uri = conn.build_url('/path', { key: 'value' })
uri = conn.build_url
uri.path

Faraday::FlatParamsEncoder.sort_params = true
Faraday::FlatParamsEncoder.sort_params
Faraday::FlatParamsEncoder.encode(a: :x)
Expand Down
2 changes: 2 additions & 0 deletions gems/faraday/2.5/faraday.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ module Faraday
def post: (?String | URI url, ?untyped body, ?untyped headers) ?{ (Faraday::Request) -> void } -> Faraday::Response
def put: (?String | URI url, ?untyped body, ?untyped headers) ?{ (Faraday::Request) -> void } -> Faraday::Response
def patch: (?String | URI url, ?untyped body, ?untyped headers) ?{ (Faraday::Request) -> void } -> Faraday::Response

def build_url: (?String | URI | nil url, ?Hash[Symbol | String, untyped]? extra_params) -> URI::HTTP
end

class SSLOptions
Expand Down