Fix avatar image placement in Firefox#293
Closed
lsouoliveira wants to merge 1 commit intoruby-ui:mainfrom
Closed
Conversation
owalmirneto
approved these changes
Jun 10, 2025
|
Ping |
|
As we talked in private, the problem is that AvatarFallback name is misleading, in the current code it isn't a fallback, it's just a element behind/above another element. I think we should implement a proper fallback behavior here using native HTML events (eg. This solution doesn't fix the problem entirely, eg.: Avatar do
AvatarImage(src: "wrong-url", alt: "joeldrapper")
AvatarFallback { "JD" }
endThis keeps breaking even with this PR. |
Contributor
Author
|
I'm closing this PR for now. As Stephann suggested, a good next step would be to handle image loading errors and display the fallback dynamically. Someone else can pick this up and continue from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the avatar image placement on Firefox. Issue #259.
Before:

After:
