Avoid auth-sanitizer top-level namespaces#13
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the auth-sanitizer integration so require "oauth/tty" no longer introduces top-level Auth / AuthSanitizer constants, keeping the sanitizer loaded and referenced under the OAuth::TTY namespace to avoid downstream constant collisions.
Changes:
- Added an internal isolated loader (
OAuth::TTY::AUTH_SANITIZER) to loadauth-sanitizerwithout defining top-level namespaces. - Updated
Command(and its RBS signature) to includeOAuth::TTY::AUTH_SANITIZER::FilteredAttributesinstead ofAuth::Sanitizer::FilteredAttributes. - Bumped the gem version to
1.0.8and tightened theauth-sanitizerdependency to>= 0.1.3.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/oauth/tty/auth_sanitizer.rb |
Introduces the isolated loader that returns a sanitizer module without leaking top-level constants. |
lib/oauth/tty.rb |
Stops requiring auth/sanitizer directly; loads the internal isolated loader instead. |
lib/oauth/tty/command.rb |
Switches FilteredAttributes include to the namespaced isolated sanitizer constant. |
sig/oauth/tty/command.rbs |
Aligns the type signature with the new include target. |
spec/oauth/tty/auth_sanitizer_spec.rb |
Adds coverage asserting no top-level constants are introduced and that Command includes FilteredAttributes. |
oauth-tty.gemspec |
Pins auth-sanitizer to >= 0.1.3 within ~> 0.1. |
lib/oauth/tty/version.rb |
Bumps version to 1.0.8. |
Gemfile.lock |
Reflects the version bump and dependency update to auth-sanitizer 0.1.3. |
CHANGELOG.md |
Documents the fix under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing