fix: subcommand routing drops unrecognized subcommands (#600)#601
Open
pszymkowiak wants to merge 1 commit intodevelopfrom
Open
fix: subcommand routing drops unrecognized subcommands (#600)#601pszymkowiak wants to merge 1 commit intodevelopfrom
pszymkowiak wants to merge 1 commit intodevelopfrom
Conversation
- git stash: pass unknown subcommands (save, branch, clear) through instead of silently falling back to git stash push - git branch: add --show-current, --set-upstream-to, --format, --sort to flag detection so they don't get overridden by -a injection - pip: replace bail!() with passthrough for unknown subcommands (freeze, download, wheel, etc.) Fixes #600 Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three command modules that silently drop or misroute unrecognized subcommands:
save,branch,clear,storefell into default_ =>which rangit stash(push) without the subcommand — now passes through correctly--show-current,--set-upstream-to,--format,--sort,--points-atwere not detected —--show-currentreturned a branch list instead of the current branch namebail!()on unknown subcommands (freeze,download,wheel) — now falls through to passthroughTest plan
cargo fmt --all --check— cleancargo test --all— 920 passedrtk git stash clear→ok stash clear(was:ok (nothing to stash))rtk git branch --show-current→fix/subcommand-routing-600(was: full branch list)rtk pip freeze→ pip output (was:unsupported subcommand 'freeze')/rtk-checkfull health check — 37/41 Rust, 15/15 TOML, 18/20 rewrite (all failures preexisting)Fixes #600