Skip to content

fix: rewrite docker-compose (legacy hyphenated CLI) to rtk docker compose#579

Open
slice-mihird wants to merge 1 commit intortk-ai:developfrom
slice-mihird:fix/docker-compose-legacy-rewrite
Open

fix: rewrite docker-compose (legacy hyphenated CLI) to rtk docker compose#579
slice-mihird wants to merge 1 commit intortk-ai:developfrom
slice-mihird:fix/docker-compose-legacy-rewrite

Conversation

@slice-mihird
Copy link

Problem

Users on the legacy docker-compose CLI (hyphenated, v1) get 0% savings — the rewrite registry only handles docker compose (space-separated, v2). From rtk discover on a real machine, 40+ runs of docker-compose logs are fully missed.

Solution

Add a PATTERN and RtkRule for docker-compose that maps supported subcommands to rtk docker compose:

Command Rewrites to
docker-compose ps rtk docker compose ps
docker-compose logs [service] rtk docker compose logs [service]
docker-compose build [service] rtk docker compose build [service]
docker-compose up (not rewritten — passthrough)
docker-compose down (not rewritten — passthrough)

The filter code in container.rs already handles all three supported subcommands — this PR only adds the missing rewrite routing.

Changes

  • src/discover/rules.rs: new pattern + RtkRule for docker-compose
  • src/discover/registry.rs: 6 tests (3 supported, 3 skipped)

Testing

All 6 new tests cover the supported/skipped split:

test_rewrite_docker_compose_legacy_ps         ✓
test_rewrite_docker_compose_legacy_logs       ✓
test_rewrite_docker_compose_legacy_logs_no_service ✓
test_rewrite_docker_compose_legacy_build      ✓
test_rewrite_docker_compose_legacy_up_skipped ✓
test_rewrite_docker_compose_legacy_down_skipped ✓

Relates to #578.

🤖 Generated with Claude Code

…pose

docker-compose ps/logs/build → rtk docker compose ps/logs/build
docker-compose up/down/etc → not rewritten (unsupported, pass through)

Adds a new PATTERN and RtkRule for the legacy docker-compose CLI so
that users still on the hyphenated binary get the same token savings
as docker compose users. Includes 6 tests covering supported and
skipped subcommands.

Closes rtk-ai#578

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pszymkowiak
Copy link
Collaborator

Please retarget this PR to develop instead of master. We use develop as the integration branch — master is for releases only. You can change the base branch in the PR settings. Thanks!

@pszymkowiak pszymkowiak added the wrong-base PR targets master instead of develop label Mar 17, 2026
@slice-mihird slice-mihird changed the base branch from master to develop March 17, 2026 15:02
@slice-mihird
Copy link
Author

Done — retargeted to develop. Apologies for the wrong base!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wrong-base PR targets master instead of develop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants