fix: skip rewriting find/fd in pipes (#439)#563
Open
pszymkowiak wants to merge 1 commit intodevelopfrom
Open
Conversation
…439) rtk find outputs a grouped format incompatible with pipe consumers like xargs, grep, wc, sort. Skip rewrite when find/fd is followed by a pipe, preserving native one-per-line output. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
Collaborator
Author
|
Tested manually:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find/fdwhen followed by a pipe (|)rtk findoutputs a grouped format (files space-separated) incompatible with pipe consumers likexargs,grep,wc,sortwhich expect one path per linefindwithout a pipe is still rewritten tortk find(savings preserved)Before
After
Tests
test_rewrite_find_pipe_skipped— find with xargs not rewrittentest_rewrite_find_pipe_xargs_wc— find with wc not rewrittentest_rewrite_find_no_pipe_still_rewritten— find alone still rewrittenFixes #439