feat(cpp): add CMake, CTest, Make, Ninja, and MSBuild handlers - #3455
Open
isink17 wants to merge 1 commit into
Open
feat(cpp): add CMake, CTest, Make, Ninja, and MSBuild handlers#3455isink17 wants to merge 1 commit into
isink17 wants to merge 1 commit into
Conversation
Add token-efficient output handlers and safe command rewrites for common C++ build and test workflows. Preserve command arguments and execution semantics while reducing CMake, CTest, Make, Ninja, and MSBuild output noise.
isink17
force-pushed
the
feat/cpp-build-handlers-v2
branch
from
August 6, 2026 12:22
829cc0e to
7202519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused, token-efficient output handlers and safe automatic rewrites for common C++ build and test workflows:
The handlers preserve the original executable arguments, targets, configuration, platform, environment, working directory, and native exit code while reducing progress and build noise.
Correctness and failure handling
<tool>: failed (exit N)result.RunOptions::preserve_filtered_failure_output; existing callers and defaultnever_worsebehavior remain unchanged./t:Linkremains/t:Link; no build target is changed.Supported diagnostics
FAILED:blocks and failure sentinelsRewrite safety
Automatic rewriting is limited to normal build and test invocations.
Native output is preserved for informational, query, structured-output, dry-run, debug, and tool modes, including:
Make lifecycle targets such as
clean,install, anddistcleanremain native. Make option parsing handles clustered flags, options occurring after targets or assignments, option operands, and the--boundary.Command arguments and ordering are preserved.
Validation
cargo check --all-targets: passedcargo fmt --all -- --check: passedcargo clippy --all-targets: passedThe full branch suite completed with:
Existing upstream failure:
grep_no_match_emits_empty_not_a_messageThe same
Some(2)versusSome(1)failure was reproduced on a detached cleanupstream/developworktree.Scope
This PR intentionally excludes PowerShell rewriting, grep/JSON additions, codegraph handling, patch/encoding changes, Git normalization, and other unrelated features. Those will be handled separately.