fix(find/git): avoid UTF-8 mid-char byte-slice panics - #3435
Open
mohammedelkarsh wants to merge 1 commit into
Open
fix(find/git): avoid UTF-8 mid-char byte-slice panics#3435mohammedelkarsh wants to merge 1 commit into
mohammedelkarsh wants to merge 1 commit into
Conversation
Truncate find path display with floor_char_boundary, and parse git commit output via strip_prefix so non-ASCII / malformed first lines cannot panic. Fixes rtk-ai#3415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk finddisplay truncation so paths longer than 50 bytes truncate on char boundaries (Thai/CJK paths no longer panic).parse_commit_outputto require a leading[viastrip_prefixinstead of&line[1..], so hook noise / multibyte first lines cannot panic.rtk findpanics on a non-ASCII directory path >50 bytes, andrtk git commitpanics when the first output line does not start with[#3415.Fixes #3415
Test plan
cargo test --bin rtk truncate_path_displaycargo test --bin rtk test_parse_commit_outputcargo fmt --allcargo clippy --bin rtk --all-targets -- -D warnings