Skip to content

ci: don't persist-credentials on public workflow#49

Merged
justlevine merged 3 commits into
mainfrom
ci/don't-persist-creds
May 24, 2026
Merged

ci: don't persist-credentials on public workflow#49
justlevine merged 3 commits into
mainfrom
ci/don't-persist-creds

Conversation

@justlevine
Copy link
Copy Markdown
Collaborator

@justlevine justlevine commented May 24, 2026

What

Sets persist-credentials: false for public CI repo, and updates docs accordingly.

Why

Related Issue(s):

How

AI Disclosure

Testing Instructions

Screenshots

Additional Info

Checklist

Open WordPress Playground Preview

Copilot AI review requested due to automatic review settings May 24, 2026 20:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI setup for public repositories to avoid persisting GitHub credentials during checkout, and adjusts workflow documentation to describe public vs private workflow variants.

Changes:

  • Set actions/checkout persist-credentials: false in .github/workflows/ci.yml.
  • Updated .github/workflows/README.md guidance around using *-public.yml workflow variants.
  • Downgraded @wordpress/use-recommended-components from error to warn in eslint.config.mjs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
eslint.config.mjs Relaxes one WordPress ESLint rule severity (unrelated to CI credential persistence).
.github/workflows/README.md Updates documentation about public/private reusable workflow variants and checkout credentials.
.github/workflows/ci.yml Disables persisted checkout credentials in the detect job for public CI usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/README.md Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread eslint.config.mjs
justlevine and others added 2 commits May 24, 2026 23:56
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@justlevine justlevine merged commit 6c04868 into main May 24, 2026
16 checks passed
@justlevine justlevine deleted the ci/don't-persist-creds branch May 24, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants