Use double-tilde for strikethrough in Markdown tests#4144
Merged
Conversation
The current dev version of commonmark has disabled single tilde for strikethrough: r-lib/commonmark#33 Using double-tilde will make it consistent with Pandoc's Markdown (where single-tilde is for subscripts).
Collaborator
|
Thanks, do you have a timeline in mind for submitting commonmark to CRAN? |
cpsievert
approved these changes
Oct 15, 2024
Contributor
Author
|
I don't, but Jeroen just made a release earlier this month and I'm currently proposing another feature to commonmark, so the next release may not happen very soon. This particular issue is not urgent, but it will make it possible for me to get rid of an ugly hack in my package. If you can make a new CRAN release of shiny at some point this year, that should be good enough to me. Thanks! |
cpsievert
reviewed
Oct 15, 2024
cpsievert
reviewed
Oct 15, 2024
cpsievert
reviewed
Oct 15, 2024
Contributor
Author
|
You don't have to skip tests for lower versions of commonmark, because double-tilde works for lower versions, too. Perhaps I didn't make it clear:
|
This reverts commit 97bee20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current dev version of commonmark has disabled single tilde for strikethrough: r-lib/commonmark#33 Using double-tilde will make it consistent with Pandoc's Markdown (where single-tilde is for subscripts).