Skip to content

chore(deps): update dependency html-loader to v5 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency html-loader to v5 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"fastify-static": "^4.7.0",
"file-loader": "^6.2.0",
"get-port": "^5.1.1",
"html-loader": "2.1.2",
"html-loader": "5.1.0",

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add Node.js engine requirement to match html-loader 5.1.0's constraint.

The html-loader@5.1.0 requires Node.js >= 18.12.0 (as shown in the pnpm-lock.yaml resolution), but the engines field in package.json does not declare this constraint. Without this declaration, developers and CI agents using Node < 18.12.0 will encounter runtime failures despite successful installation, as pnpm does not enforce peer/transitive engine constraints at install time.

🛠️ Proposed fix to declare Node.js engine requirement 
   "engines": {
+    "node": ">= 18.12.0",
     "pnpm": "11.1.2"
   },
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 39, The package.json file declares html-loader@5.1.0
which requires Node.js >= 18.12.0, but this Node.js engine constraint is not
declared in the engines field. Add or update the engines field in package.json
to specify the minimum Node.js version as 18.12.0 to ensure developers and CI
systems are aware of this requirement and prevent runtime failures.

"html-webpack-plugin": "5.6.7",
"jsdom": "^25.0.1",
"lodash": "^4.18.1",
Expand Down
71 changes: 20 additions & 51 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.