Skip to content

chore(deps): update dependency get-port to v7 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency get-port to v7 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"fastify-graceful-shutdown": "^4.0.1",
"fastify-static": "^4.7.0",
"file-loader": "^6.2.0",
"get-port": "^5.1.1",
"get-port": "^7.2.0",

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Node/pnpm engine declarations =="
fd -HI 'package.json|.nvmrc|.node-version|.tool-versions' | while read -r f; do
  echo "--- $f"
  sed -n '1,220p' "$f"
done

echo
echo "== CI/workflow node-version references =="
rg -n -C2 'node-version|setup-node|actions/setup-node|NODE_VERSION' .github/workflows || true

echo
echo "== get-port usage patterns that may be impacted by v6+ API changes =="
rg -n -C3 --type=js --type=ts --type=mjs --type=cjs 'get-port|makeRange|portNumbers|clearLockedPorts|reserve'

Repository: rstackjs/rspack-plugin-ci

Length of output: 17103

🏁 Script executed:

cat .github/workflows/test.yml

Repository: rstackjs/rspack-plugin-ci

Length of output: 1466

🏁 Script executed:

rg -n 'matrix|node' .github/workflows/test.yml | head -20

Repository: rstackjs/rspack-plugin-ci

Length of output: 412

Add explicit Node engine constraint to match get-port@7.2.0 requirement.

get-port@7.2.0 requires Node >=16, but package.json does not declare a Node engine floor—only pnpm version is constrained. While CI tests only Node 22.x (which satisfies the requirement), the missing constraint leaves a gap where local installs could use unsupported versions. Add "node": ">=16" to the engines field for clarity and to prevent version mismatches.

Note: get-port is not directly used in the codebase, so the risk of breaking changes from the v5→v7 upgrade is low.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 38, The package.json file is missing an explicit Node
engine constraint even though the newly added get-port@7.2.0 dependency requires
Node >=16. Add "node": ">=16" to the engines field in package.json to declare
this minimum Node version requirement and prevent unsupported local
installations.

"html-loader": "2.1.2",
"html-webpack-plugin": "5.6.7",
"jsdom": "^25.0.1",
Expand Down
12 changes: 6 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading