Skip to content

chore(deps): update dependency fastify-graceful-shutdown to v5 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency fastify-graceful-shutdown to v5 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@types/fastify-static": "^2.2.3",
"@types/node": "^14.18.63",
"fastify": "^3.29.5",
"fastify-graceful-shutdown": "^4.0.1",
"fastify-graceful-shutdown": "^5.0.0",
Comment on lines 42 to +43

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

Does fastify-graceful-shutdown v5 work with Fastify v3, or does it require Fastify v5?

💡 Result:

fastify-graceful-shutdown v5 requires Fastify >=5; it is not intended to work with Fastify v3. The plugin’s own documentation/compatibility statement says “Fastify >=5” [1][2]. Additionally, npm metadata for v5.0.0 shows a development dependency on fastify ^5.6.0, consistent with the same compatibility baseline [3][2]. (There are older releases that supported Fastify >=3, e.g., a 2021 issue references fastify version >= 3.14.2 with graceful-shutdown v3.x, but that is not v5.) [4]

Citations:

Critical: fastify-graceful-shutdown v5 requires Fastify >=5, but the project uses Fastify ^3.29.5

  • fastify-graceful-shutdown@^5.0.0 is intended for Fastify >=5, so keeping fastify@^3.29.5 (Fastify v3) is an incompatible major-version pairing that can break at startup.
  • Upgrade fastify to v5 in the PR (or downgrade fastify-graceful-shutdown to a version that supports Fastify v3).
  • Ensure the required Node version for v5 (e.g., Node >=20) is enforced via engines.node if applicable.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` around lines 42 - 43, package.json currently pins "fastify":
"^3.29.5" while also adding "fastify-graceful-shutdown": "^5.0.0", which is
incompatible; either upgrade "fastify" to a v5-compatible range (e.g., ^5.x) and
update "engines.node" to the Node version required by Fastify v5 (e.g., ">=20")
or change "fastify-graceful-shutdown" to a v4 (or other) release that supports
Fastify v3—edit the dependencies accordingly in package.json and ensure the
chosen pairing (fastify vs fastify-graceful-shutdown) is consistent across the
file.

"fastify-static": "^4.7.0",
"get-port": "^5.1.1",
"puppeteer": "^24.43.1",
Expand Down
18 changes: 9 additions & 9 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading