Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
672 changes: 399 additions & 273 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion sri-plugin/examples/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"expect": "^26.6.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/disabled/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/dll-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/dynamic-modified/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/dynamic-named-chunks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/electron-renderer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/hwp-basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/hwp-custom-template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"htmlparser2": "^8.0.2",
"mini-css-extract-plugin": "^1.6.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/hwp-externals/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"html-webpack-plugin": "^5.6.7",
"htmlparser2": "^8.0.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/hwp-output-parent-dir/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"html-webpack-plugin": "^5.6.7",
"htmlparser2": "^8.0.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/hwp-public-path/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"html-webpack-plugin": "^5.6.7",
"htmlparser2": "^8.0.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/hwp-subdirectories/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"html-webpack-plugin": "^5.6.7",
"htmlparser2": "^8.0.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/issue-147/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"script-ext-html-webpack-plugin": "^2.1.5",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/issue-152/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"expect": "^26.6.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/issue-154/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"html-webpack-plugin": "^5.6.7",
"mini-css-extract-plugin": "^1.6.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/issue-221/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/lazy-e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/lazy-hashes-cycles/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/lazy-hashes-group/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/lazy-hashes-simple/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/lazy-modified/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/mini-css-extract-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"html-webpack-plugin": "^5.6.7",
"mini-css-extract-plugin": "^1.6.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/minimal-sri-hashes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/multiple-common-chunks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify npm compatibility across a sample of examples after webpack 5.104.1 upgrade

# Test: Run npm ci and example tests in representative example directories
examples=("sri-plugin/examples/multiple-common-chunks" "sri-plugin/examples/non-web-build" "sri-plugin/examples/terser-banner")

for example_dir in "${examples[@]}"; do
  echo "Testing: $example_dir"
  cd "$example_dir" || exit 1
  
  # Check for package-lock.json to verify npm ci compatibility
  if [ -f "package-lock.json" ]; then
    echo "  ✓ package-lock.json found"
  else
    echo "  ⚠ No package-lock.json; npm versions may vary"
  fi
  
  # Check if example directory has webpack.config.js
  if [ -f "webpack.config.js" ]; then
    echo "  ✓ webpack.config.js found"
  else
    echo "  ⚠ No webpack.config.js in this example"
  fi
  
  cd - > /dev/null || exit 1
done

# Verify all 38 examples have webpack in devDependencies with version 5.104.1
echo ""
echo "Verifying all 38 examples have webpack 5.104.1:"
rg -A2 '"webpack"' --glob 'sri-plugin/examples/*/package.json' | grep -c '5.104.1'

Repository: rstackjs/rspack-plugin-ci

Length of output: 487


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Count example package.json files
echo "Counting example package.json files:"
find sri-plugin/examples -maxdepth 2 -name package.json | wc -l

# Show how many examples pin webpack to 5.104.1
echo "Counting occurrences of webpack=5.104.1 in example package.json:"
rg -N '"webpack"\s*:\s*"5\.104\.1"' sri-plugin/examples/*/package.json | wc -l

# Count occurrences of companion deps pinned versions
echo "Counting occurrences of html-webpack-plugin=5.6.3:"
rg -N '"html-webpack-plugin"\s*:\s*"5\.6\.3"' sri-plugin/examples/*/package.json | wc -l

echo "Counting occurrences of webpack-cli=5.1.4:"
rg -N '"webpack-cli"\s*:\s*"5\.1\.4"' sri-plugin/examples/*/package.json | wc -l

# Report which examples (package.json paths) do NOT match webpack 5.104.1
echo
echo "Examples not pinning webpack to 5.104.1:"
for pkg in sri-plugin/examples/*/package.json; do
  if ! rg -q '"webpack"\s*:\s*"5\.104\.1"' "$pkg"; then
    echo " - $pkg"
  fi
done

# Report which examples pin companion deps to different versions (or omit them)
echo
echo "Examples not pinning html-webpack-plugin to 5.6.3:"
for pkg in sri-plugin/examples/*/package.json; do
  if ! rg -q '"html-webpack-plugin"\s*:\s*"5\.6\.3"' "$pkg"; then
    echo " - $pkg"
  fi
done

echo
echo "Examples not pinning webpack-cli to 5.1.4:"
for pkg in sri-plugin/examples/*/package.json; do
  if ! rg -q '"webpack-cli"\s*:\s*"5\.1\.4"' "$pkg"; then
    echo " - $pkg"
  fi
done

Repository: rstackjs/rspack-plugin-ci

Length of output: 230


🏁 Script executed:

#!/bin/bash
set -u

# Total example package.json files
echo "Counting example package.json files:"
find sri-plugin/examples -maxdepth 2 -name package.json | wc -l

# Helper: count regex matches but don't fail on 0
count_matches() {
  local pattern="$1"
  local label="$2"
  local glob="$3"
  local count
  count=$(rg -N --no-mmap "$pattern" $glob 2>/dev/null | wc -l || true)
  printf "%s: %s\n" "$label" "$count"
}

glob='sri-plugin/examples/*/package.json'

count_matches '"webpack"\s*:\s*"5\.104\.1"' 'webpack=5.104.1 occurrences' "$glob"
count_matches '"html-webpack-plugin"\s*:\s*"[^"]+"' 'html-webpack-plugin pinned version occurrences' "$glob"
count_matches '"webpack-cli"\s*:\s*"[^"]+"' 'webpack-cli pinned version occurrences' "$glob"

# Show distinct pinned versions for html-webpack-plugin and webpack-cli
echo
echo "Distinct html-webpack-plugin versions (if any):"
rg -N '"html-webpack-plugin"\s*:\s*"([^"]+)"' $glob --replace '$1' 2>/dev/null | sort -u || true

echo
echo "Distinct webpack-cli versions (if any):"
rg -N '"webpack-cli"\s*:\s*"([^"]+)"' $glob --replace '$1' 2>/dev/null | sort -u || true

# Quick sample: show one package.json that has html-webpack-plugin and one that has webpack-cli
echo
echo "Example package.json containing html-webpack-plugin:"
ls -1 sri-plugin/examples/*/package.json | head -n 50 | xargs -I{} sh -c 'rg -q "\"html-webpack-plugin\"" "{}" && echo {}' | head -n 3 || true

echo
echo "Example package.json containing webpack-cli:"
ls -1 sri-plugin/examples/*/package.json | head -n 50 | xargs -I{} sh -c 'rg -q "\"webpack-cli\"" "{}" && echo {}' | head -n 3 || true

Repository: rstackjs/rspack-plugin-ci

Length of output: 5235


🏁 Script executed:

#!/bin/bash
set -u

glob='sri-plugin/examples/*/package.json'

echo "List example package.json files missing html-webpack-plugin ^5.6.3:"
for pkg in $glob; do
  if ! rg -q '"html-webpack-plugin"\s*:\s*"\^5\.6\.3"' "$pkg"; then
    echo " - $pkg"
  fi
done

echo
echo "Count package-lock.json across examples:"
find sri-plugin/examples -maxdepth 2 -name package-lock.json | wc -l

echo
echo "Examples that contain package-lock.json (if any):"
find sri-plugin/examples -maxdepth 2 -name package-lock.json -print

Repository: rstackjs/rspack-plugin-ci

Length of output: 320


Refine compatibility verification for the webpack 5.104.1 bump

All 37 example package.json files pin "webpack": "5.104.1", and "webpack-cli": "5.1.4" is uniform. "html-webpack-plugin" is only pinned to ^5.6.3 in 35 examples; sri-plugin/examples/basic/package.json and sri-plugin/examples/issue-152/package.json use a different version, so they must be included in the compatibility check. Also, there are no package-lock.json files in sri-plugin/examples/*, so npm ci won’t work—run the examples via the repo’s normal install flow (e.g., npm install) and then npm test (or the example test command) in representative examples (or all examples if feasible).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sri-plugin/examples/multiple-common-chunks/package.json` at line 11, The
compatibility check that validated the bump to "webpack": "5.104.1" and
"webpack-cli": "5.1.4" must be expanded to include examples that use a different
html-webpack-plugin version; update the verification scope to cover all
sri-plugin/examples/* package.json files (noting all 37 pin webpack/webpack-cli)
and explicitly include sri-plugin/examples/basic/package.json and
sri-plugin/examples/issue-152/package.json which deviate on html-webpack-plugin;
also change the test/run procedure to not use npm ci (there are no
package-lock.json files in sri-plugin/examples/*) and instead run the examples
via the repo’s normal install flow (npm install) then run npm test or the
example-specific test command for representative examples (or all examples if
feasible).

"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/mutually-dependent-chunks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/no-error-invalid-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/no-warn-filename/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/non-web-build/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/sourcemap-code-splitting/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/terser-banner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"terser-webpack-plugin": "^5.6.1",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/warn-hot-reload/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/webpack-assets-manifest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"expect": "^26.6.2",
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-assets-manifest": "3.1.1",
"webpack-cli": "5.1.4"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"html-webpack-plugin": "^5.6.7",
"mini-css-extract-plugin": "^1.6.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-assets-manifest": "3.1.1",
"webpack-cli": "5.1.4",
"webpack-fix-style-only-entries": "0.6.1"
Expand Down
2 changes: 1 addition & 1 deletion sri-plugin/examples/webpack-preload/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"html-webpack-plugin": "^5.6.7",
"mini-css-extract-plugin": "^1.6.2",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}
2 changes: 1 addition & 1 deletion sri-plugin/examples/webpack4-contenthash/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"devDependencies": {
"html-webpack-plugin": "^5.6.7",
"nyc": "*",
"webpack": "5.98.0",
"webpack": "5.104.1",
"webpack-cli": "5.1.4"
}
}