Skip to content

fix: rename default ipc socket#233

Open
chenjiahan wants to merge 2 commits into
mainfrom
chenjiahan/rename-ipc-socket
Open

fix: rename default ipc socket#233
chenjiahan wants to merge 2 commits into
mainfrom
chenjiahan/rename-ipc-socket

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR renames the default IPC socket generated by ipc: true from webpack-dev-server.sock to rspack-dev-server.sock, matching the package name and avoiding webpack-prefixed defaults. It also updates the IPC e2e test socket names to use the same Rspack prefix.

Validation

  • node_modules/.bin/prettier --check src/server.ts tests/e2e/ipc.test.js
  • node_modules/.bin/rslint src/server.ts tests/e2e/ipc.test.js
  • node_modules/.bin/rstest tests/e2e/ipc.test.js

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 27886534-1c1e-4cb6-8908-6fe09b5e44fd

📥 Commits

Reviewing files that changed from the base of the PR and between 017039b and 39b854c.

📒 Files selected for processing (2)
  • src/server.ts
  • tests/e2e/ipc.test.js

📝 Walkthrough

Walkthrough

The default IPC socket filename is renamed from webpack-dev-server.sock to rspack-dev-server.sock in src/server.ts. This change applies only when options.ipc is set to true (boolean); all other IPC path-handling logic is unchanged. Two corresponding assertions in tests/e2e/ipc.test.js are updated to expect the new rspack-dev-server.${process.pid}-N.sock filename pattern.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: rename default ipc socket' directly and clearly summarizes the main change - renaming the default IPC socket filename from webpack-dev-server.sock to rspack-dev-server.sock.
Description check ✅ Passed The description is directly related to the changeset, providing clear context about the socket name change from webpack-dev-server.sock to rspack-dev-server.sock and noting test updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/rename-ipc-socket

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant