Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ rspack_error = { version = "=0.100.5" }
rspack_hook = { version = "=0.100.5" }

async-trait = { version = "0.1" }
rspack_sources = { version = "0.4.21" }
rspack_sources = { version = "0.100.0" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚑ Quick win

Version mismatch with other rspack dependencies.

All other rspack dependencies (lines 9-13) are pinned to exact version =0.100.5, but rspack_sources is being updated to 0.100.0. This creates two issues:

  1. Version discrepancy: rspack_sources at 0.100.0 while other rspack monorepo packages are at 0.100.5, which may cause compatibility issues.
  2. Constraint inconsistency: Missing the = prefix that other rspack dependencies use for exact version pinning, allowing any 0.100.x version instead of exactly 0.100.0.
πŸ”§ Suggested fix
-rspack_sources = { version = "0.100.0" }
+rspack_sources = { version = "=0.100.5" }
πŸ“ Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
rspack_sources = { version = "0.100.0" }
rspack_sources = { version = "=0.100.5" }
πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` at line 16, The Cargo.toml dependency rspack_sources is
inconsistent with the other rspack packages: change the entry rspack_sources = {
version = "0.100.0" } to pin the exact same version and format as the others by
using rspack_sources = { version = "=0.100.5" } so it matches the other rspack
dependencies' exact-version constraint and avoids compatibility drift.


rspack_binding_build = { version = "=0.100.5" }
rspack_binding_builder = { version = "=0.100.5" }
Expand Down
Loading