chore(infra): enable tsgo, publint, and prettier checks#93
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR tightens project tooling around linting/formatting, package publish validation, and TypeScript declaration generation.
Changes:
- Add JS recommended rules to Rslint, and extend
lint/lint:writeto include Prettier. - Add Publint checks to the build and switch DTS generation to
tsgo. - Add repository URL prefix and introduce
@typescript/native-preview+rsbuild-plugin-publintdev dependencies.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/createLogger.ts | Code style-only change (condensed ternary). |
| rslint.config.ts | Enable JS recommended lint config alongside TS. |
| rslib.config.ts | Add Publint plugin and enable tsgo for DTS generation. |
| package.json | Update repo URL; add Prettier to lint scripts; add new dev deps. |
| AGENTS.md | Add contributor/agent guidance and repo commands. |
| .github/workflows/test.yml | Remove Playwright install step from CI. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Related skill PR: rstackjs/agent-skills#78 This PR is another test run of the |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR introduces lint scripts ( 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
rslint.config.ts (1)
5-5: Remove unnecessaryjs.configs.recommendedor keep for future JavaScript support.The repository contains no JavaScript files (
.js,.jsx,.mjs,.cjs), so this ESLint configuration is currently unused. Remove it if JavaScript files are not planned, or keep it if you intend to add JavaScript files later.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rslint.config.ts` at line 5, The js.configs.recommended configuration in rslint.config.ts (line 5) is currently unused because the repository contains no JavaScript files. Either remove this line entirely if JavaScript file support is not planned, or retain it if you intend to add JavaScript files to the project in the future. Make a deliberate choice based on your project's roadmap and document it if keeping it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 34: The `@typescript/native-preview` package at version
7.0.0-dev.20260615.1 is experimental and not recommended for production use,
which poses risks for a published library whose type declarations are consumed
downstream. Either: (1) revert the `@typescript/native-preview` dependency to a
stable TypeScript version in package.json to ensure reliable DTS generation for
consumers, or (2) if accepting the early-adoption risks, document this decision
and the known issues (incomplete declaration emission feature parity, incorrect
inlining of named inferred types) in the project's documentation or comments so
that maintainers and users are aware of the potential instability in generated
type declarations.
---
Nitpick comments:
In `@rslint.config.ts`:
- Line 5: The js.configs.recommended configuration in rslint.config.ts (line 5)
is currently unused because the repository contains no JavaScript files. Either
remove this line entirely if JavaScript file support is not planned, or retain
it if you intend to add JavaScript files to the project in the future. Make a
deliberate choice based on your project's roadmap and document it if keeping it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 766c6118-3df4-4242-80e0-016843c3d973
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
.github/workflows/test.ymlAGENTS.mdpackage.jsonrslib.config.tsrslint.config.tssrc/createLogger.ts
💤 Files with no reviewable changes (1)
- .github/workflows/test.yml
aa119e7 to
08a7d90
Compare
08a7d90 to
910b5a1
Compare
Summary
This PR was recreated from the latest
origin/mainon a new branch. It tightens the rslog infrastructure baseline without changing runtime behavior: Rslib declaration generation now uses tsgo, publint runs during build, linting includes JS recommended rules plus Prettier checks, agent guidance is documented, and the unused Playwright install step is removed from CI.Notes: