fix: flaky tests due to corepack concurrency on Windows#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throwOnError: truetoxcall increateTarballto surface exact errors ifnpm packorpnpm packfails.fs.unlinkerrors during async disposal to avoid masking the original error when tests fail early.test/npm,test/pnpm, andtest/pnpm-workspacepackage.json files to include identical package manager hashes as the root package.json (or valid resolved hashes) to prevent corepack from concurrently downloading versions on Windows which causes file lock hangs/timeouts.