refactor: remove options json#46
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the standalone src/options.json schema file and replaces its usage with an explicit list of plugin-only option keys in src/options.js, preserving the behavior of getESLintOptions while avoiding JSON module imports.
Changes:
- Deleted
src/options.jsonand removed its JSON import usage. - Added
pluginOnlyOptionKeysinsrc/options.jsto filter plugin-specific options before passing options to ESLint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/options.json | Removed the standalone options schema JSON file. |
| src/options.js | Replaced schema-driven option filtering with a hardcoded list of plugin-only option keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the standalone options JSON schema file and keeps plugin-specific option filtering in
src/options.js, avoiding the JSON module import while preservinggetESLintOptionsbehavior.