fix: support absolute eslintPath file paths#45
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates getESLint’s module-loading logic so absolute eslintPath values are resolved via Node CommonJS resolution before importing, aligning them with the existing path-style fallback behavior and avoiding ESM import pitfalls (notably on Windows-style absolute paths). It also adds a regression test intended to cover loading ESLint from an absolute file path.
Changes:
- Add absolute-path detection for
eslintPathand route those specifiers throughrequire.resolve()+import(fileURL). - Refactor the CommonJS-resolution import path into a shared
loadResolvedModule()helper. - Add a test case for using an absolute file path
eslintPath.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/eslint-path.test.js | Adds a regression test for loading ESLint via an absolute file path. |
| src/getESLint.js | Adds absolute-path handling and refactors CommonJS-resolution import into a helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes absolute
eslintPathfile paths so they are resolved with Node CommonJS resolution before importing, matching the existing path-style fallback without changing package specifier handling. It also adds a regression test that loads the mocked ESLint module from an absolute file path.