Skip to content

Re-order overloads for index method to fix type-checking edge case #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
startrekdude wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Re-order overloads for index method to fix type-checking edge case #101

startrekdude wants to merge 1 commit into from

Conversation

@startrekdude
Copy link

@startrekdude startrekdude commented Jan 20, 2025

Fixes #100

@startrekdude startrekdude mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bence-hervay bence-hervay bence-hervay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Order of overloads of index method can cause failure to type-check when a type is a sequence of itself (example: str)

2 participants

@startrekdude @bence-hervay