Look for base page dimensions in parent of parent in merge_pages#9
Open
ttrine wants to merge 2 commits intorschroll:masterfrom
Open
Look for base page dimensions in parent of parent in merge_pages#9ttrine wants to merge 2 commits intorschroll:masterfrom
ttrine wants to merge 2 commits intorschroll:masterfrom
Conversation
added 2 commits
June 14, 2021 16:28
…ave no MediaBox field
…e found in merge_pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi rschroll,
I'm using your library in my project and it's very useful, thanks!
This PR fixes a small issue I encountered when running this library on a few of my PDFs. I can tell by your existing comments that finding the base page dimensions is a bit of a pain point. I was able to resolve a majority of error cases I was seeing by looking for the dimensions in the parent of the parent if necessary.
If it still can't find them, I throw an exception that describes what's going on, to avoid the less-than-helpful "'NoneType' object is not iterable" that it's throwing currently.