fix(skills): enforce executing-plans review gate (#41)#76
Open
ddddddddwp wants to merge 8 commits into
Open
Conversation
Astrolabe change: enforce-executing-plans-review 验证: npm run build; npx vitest run test/ts/init-e2e.test.ts; npx vitest run test/ts/skills.test.ts test/ts/comet-scripts.test.ts test/ts/init-e2e.test.ts; npx vitest run
Astrolabe change: enforce-executing-plans-review 验证: npm run build; npx vitest run
Astrolabe change: enforce-executing-plans-review 验证: openspec validate --all
|
Too many files changed? Review this PR in Change Stack to see how the pieces fit before you dive in. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR enforces a mandatory code review gate for the ChangesExecuting-Plans Review Gate
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
/gemini review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/superpowers/plans/2026-06-03-executing-plans-review-gate.md`:
- Line 23: The heading "### Task 1: Add the Skill Safeguard Regression Test" is
an H3 under a top-level H1 with no H2 parent (MD001); fix by promoting the Task
header to an H2 (change "### Task 1: Add the Skill Safeguard Regression Test" to
"## Task 1: Add the Skill Safeguard Regression Test") or insert an appropriate
H2 parent section above it so the H3 has an H2 context; update the heading text
accordingly to preserve semantics and run the linter to confirm MD001 is
resolved.
In
`@openspec/changes/archive/2026-06-04-enforce-executing-plans-review/.astrolabe.yaml`:
- Line 15: Update the stale handoff_context value in .astrolabe.yaml so it
points to the archived location: replace the current
openspec/changes/enforce-executing-plans-review/.astrolabe/handoff/design-context.json
reference with the path under the archive
(openspec/changes/archive/2026-06-04-enforce-executing-plans-review/.astrolabe/handoff/design-context.json)
so consumers resolving the handoff_context key can find the real file; make this
change in the .astrolabe.yaml file where the handoff_context key is defined.
In `@openspec/changes/archive/2026-06-04-enforce-executing-plans-review/tasks.md`:
- Around line 2-3: Update the archived checklist so the two items are not
contradictory by making the first item describe a prior pending state and the
second item the completed follow-up; specifically, change the Line 2 text "Run
focused verification and record that English synchronization is pending user
confirmation." to a past-tense/chronological phrase such as "Ran focused
verification and recorded that English synchronization was pending user
confirmation at that step," and keep Line 3 "Sync the approved review gate to
`assets/skills/comet-build/SKILL.md` and cover it with English skill
assertions." as the completed action to make the final state unambiguous.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5c0b41b7-5d37-4079-830c-dff0132d2b3a
📒 Files selected for processing (16)
assets/skills-zh/comet-build/SKILL.mdassets/skills/comet-build/SKILL.mddocs/superpowers/plans/2026-06-03-executing-plans-review-gate.mddocs/superpowers/reports/2026-06-04-enforce-executing-plans-review-verify.mddocs/superpowers/specs/2026-06-03-executing-plans-review-gate-design.mdopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/.astrolabe.yamlopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/.astrolabe/handoff/design-context.jsonopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/.astrolabe/handoff/design-context.mdopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/.openspec.yamlopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/design.mdopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/proposal.mdopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/specs/comet-build-review-gate/spec.mdopenspec/changes/archive/2026-06-04-enforce-executing-plans-review/tasks.mdopenspec/specs/comet-build-review-gate/spec.mdtest/ts/init-e2e.test.tstest/ts/skills.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41.
What changed
executing-plansreview gate to Chinese and Englishcomet-buildskill docs..claude/skillspayload before copying to Lingma.Why
The
comet-build + executing-planspath could previously finish implementation and transition to verify without any mandatory independent review. That made the lightweight execution path weaker than intended and allowed review to be skipped.Validation
npm run buildnpx vitest run test/ts/skills.test.ts test/ts/init-e2e.test.tsgit diff --check origin/master...HEADRestores closed PR #70. The original PR could not be reopened because GitHub reports that the source repository for #70 had been deleted.
Summary by CodeRabbit
New Features
Documentation
Tests