Open
Conversation
hsingh6764
force-pushed
the
seperate-metrics-server
branch
from
e739ae9 to
71e6891
Compare
hsingh6764
force-pushed
the
seperate-metrics-server
branch
from
05bf71e to
41da576
Compare
roylines
reviewed
Aug 21, 2018
Owner
roylines
left a comment
roylines
left a comment
There was a problem hiding this comment.
Could you please extend the tests to test for the additional server option, and I will gladly merge.
lib/express.js
Outdated
| server.use(middleware) | ||
| server.get(options.url, (req, res) => { | ||
| let mertricsEndpointServer = options.metricsServer || server; | ||
| mertricsEndpointServer.get(options.url, (req, res) => { |
| register: (server, o, done) => { | ||
| server.route({ | ||
| let mertricsEndpointServer = options.metricsServer || server; | ||
| mertricsEndpointServer.route({ |
lib/http.js
Outdated
| function instrument (server, options) { | ||
| server.on('request', (request, response) => { | ||
| let mertricsEndpointServer = options.metricsServer || server; | ||
| mertricsEndpointServer.on('request', (request, response) => { |
package.json
Outdated
| { | ||
| "name": "epimetheus", | ||
| "version": "0.0.1", | ||
| "version": "1.0.56", |
Owner
There was a problem hiding this comment.
please leave version as 0.0.1 as it is automagically set by CI
Owner
|
Happy to merge this pull request if you could please add a couple of tests and fix the spelling mistakes. Thanks for the contribution. |
hsingh6764
force-pushed
the
seperate-metrics-server
branch
from
1f71bbb to
b08c313
Compare
Author
|
@roylines please take a look again |
Owner
|
@hsingh6764 there are conflicts to be resolved. Would you please be able to sort. |
|
Can this get merged + published to NPM please? |
Author
|
Can this be merged? |
|
Please... |
|
@roylines please merged this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.