Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Roy,
Following up on our thread about counting grain and provenance. Here's the fixture I mentioned, laid out the same way as David's inference-boundary entry so it sits cleanly in the evidence directory.
The setup: one
operation_id, three rows, each tagged with its provenance.The number pair you asked for:
Replay gets its own view (20 ms) and synthetic stays out of production aggregates entirely. The point is that 140 looks like a perfectly reasonable latency number, which is exactly why it's dangerous.
Files:
conformance/evidence/live-replay-synthetic-latency-basis/README.mdconformance/evidence/live-replay-synthetic-latency-basis/fixture.jsonIt's a synthetic fixture only, no real provider traffic behind it. I didn't wire it into a runner, same as the inference-boundary entry. I did recompute the three means straight from the rows to make sure the expected values in the JSON line up.
Let me know if you'd like anything renamed or reshaped.
Chandan