v0.6.5 - #177
Merged
Merged
v0.6.5#177
Conversation
The 'secrets' context cannot be used in step-level if: conditions, which made the Release workflow fail to parse on workflow_dispatch. Map the secret to a job-level env var and check that instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Address security review: replace job-level SIGNPATH_API_TOKEN env (which exposed the secret to all steps including the AI changelog) with a preliminary boolean-check step. The token is now referenced only in the check step and the SignPath action's with: block. Pin go-winres to v0.3.3 instead of @latest for supply-chain safety. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The submit-signing-request action does not accept input/output-artifact-path. It requires the artifact uploaded via actions/upload-artifact (yielding a numeric artifact-id) and writes signed output to output-artifact-directory. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Switch the signing gate from secret presence to an explicit USE_SIGNPATH flag, so releases skip signing entirely while the SignPath certificate is still pending. Set USE_SIGNPATH=true to enable once the cert is issued. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
USE_SIGNPATH is configured as a repository variable, not a secret. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The fallback path escaped the quotes around the revision range, passing
literal quotes to git ('"v0.6.1..HEAD"') and failing with exit 128 when
the AI changelog generation returned empty. Use normal shell quoting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.