fix: clarify SPIRE warning message to avoid confusion - #505
Merged
Conversation
The existing warning 'SPIRE not detected for mTLS-enabled workload' is confusing because: 1. SPIRE may be running (via Helm) but not detected by this check 2. JWT-SVID authentication works fine despite this warning 3. The check only looks for socket volumes in the pod spec This commit clarifies that: - The check is specific to X.509-SVID based mTLS - JWT-SVID authentication is unaffected - The message explains what's actually being checked Fixes rossoctl/rossoctl#2361 Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
rubambiza
reviewed
Aug 11, 2026
rubambiza
left a comment
rubambiza
left a comment
Contributor
There was a problem hiding this comment.
LGTM from a quick human review. AI-assisted review will come next with an approval and any nits/suggestions it may have from its broader context. I'm also using this to test the migrated github-pr-review skill in Claude Code 😉
rubambiza
approved these changes
Aug 11, 2026
rubambiza
left a comment
rubambiza
left a comment
Contributor
There was a problem hiding this comment.
Clear improvement — the reworded log line ("SPIRE socket volumes not detected (X.509-SVID mTLS unavailable)") is more precise than the previous "SPIRE not detected," and the added comment correctly clarifies that this check is X.509-SVID-specific and that JWT-SVID SPIFFE auth still works when SPIRE is installed. Message/comment-only; no logic change.
- nit: the PR description is empty — a short
## Summaryof the wording change would help reviewers and the changelog.
Reviewed by clawgenti using the github-pr-review skill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.