Repository navigation
fix(terminal): load node-pty from app.asar on macOS, leave PATH alone - #665
Conversation
On packaged macOS builds node-pty already rewrites its spawn-helper path to app.asar.unpacked. Requiring it from the unpacked copy made that rewrite happen twice (app.asar.unpacked.unpacked), so no shell could be started. Keep the resolved path on macOS; Windows and Linux still load the unpacked copy. Stop putting Studio's managed tools (python, dbt, rosetta) on the shell terminal's PATH, and drop the macOS login-shell wrapper that restored that order after path_helper. The terminal now starts with the PATH Studio received, like the terminal of any other editor.
|
Caution Review failedThe pull request is closed.
Warning Some tools did not complete. Review the errors below.
|
On packaged macOS builds node-pty already rewrites its spawn-helper path to app.asar.unpacked. Requiring it from the unpacked copy made that rewrite happen twice (app.asar.unpacked.unpacked), so no shell could be started. Keep the resolved path on macOS; Windows and Linux still load the unpacked copy.
Stop putting Studio's managed tools (python, dbt, rosetta) on the shell terminal's PATH, and drop the macOS login-shell wrapper that restored that order after path_helper. The terminal now starts with the PATH Studio received, like the terminal of any other editor.