Skip to content

fix(e2e): open projects from the renamed Home card and expect the wizard type step - #661

Open
Edon-Ameti wants to merge 1 commit into
devfrom
fix/e2e-project-entry-points
Open

Edon-Ameti wants to merge 1 commit into
devfrom
fix/e2e-project-entry-points

Conversation

@Edon-Ameti

@Edon-Ameti Edon-Ameti commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

What

Fixes 23 failing e2e tests after the recent UI changes on dev.

Why they failed

  • Home card renamed: the "DBT Project" card on Home is now "Projects" (Analytics project type, feat(projects): Analytics project type in Select Project and the Project screen #651). The openProjectSelection helper still clicked "DBT Project", so every test using it (project-selection, project-lifecycle, get-started-modal) timed out.
  • New Project wizard: New Project / Add project now opens a wizard that starts on the project-type step. The name field only appears after Next, so three tests that expected it right away failed.

Changes (tests only, no app code)

  • e2e/helpers/window.helper.ts: click the "Projects" card inside the Studio Modules area.
  • quick-start-tour.spec.ts, home-dashboard.spec.ts, panel-header-pickers.spec.ts: check that the wizard opens on its type step (project-type-step) instead of the name field.

Testing

Ran the 6 affected spec files locally on Windows against a fresh renderer build: 38/38 passed. The full suite was not run.

Summary by CodeRabbit

  • Tests
    • Updated checks for opening or creating a project from the Home screen, navigation panel, and onboarding tour to expect the project-type step in the flow.

…ard type step

The Home card is now titled Projects, and New Project opens the wizard on its project-type step before the name field.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The openProjectSelection helper now selects the “Projects” card on the Home screen. Three end-to-end tests now expect the project-type step after project creation is opened.

Changes: Project selection

Layer / File(s) Summary
Projects entry and wizard checks
e2e/helpers/window.helper.ts, e2e/tests/home/home-dashboard.spec.ts, e2e/tests/navigation/panel-header-pickers.spec.ts, e2e/tests/onboarding/quick-start-tour.spec.ts
The helper targets “Projects” within tour-modules-area when Home is visible. The tests check for the project-type step instead of the project-name input.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • rosettadb/dbt-studio#651: It changes project creation to include a project-type step and is related to the wizard expectations updated here.

Suggested reviewers: flakronademi

Merge Risk: Minimal · up to 2faa0

This updates end-to-end tests to match the renamed Projects card and the project-type wizard step. It does not change product behavior, and no actionable merge risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes: the e2e helper now opens projects from the renamed Home card, and the tests now expect the project-type wizard step. The raw summary confirms both: openProjectSel…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes: the e2e helper now opens projects from the renamed Home card, and the tests now expect the project-type wizard step. The raw summary confirms both: openProjectSelection clicks Projects instead of DBT Project, and three specs now expect project-type-step instead of the project name field. The title is specific and matches the changeset. It is a fix limited to tests, which the title's fix(e2e) prefix conveys.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8eef1da5-b215-4b4e-a225-0cfe636bf48c
Commits

Reviewing files that changed from the base of the PR and between dcf77e2 and 2faa060.

Files selected for processing: 4

  • e2e/helpers/window.helper.ts
  • e2e/tests/home/home-dashboard.spec.ts
  • e2e/tests/navigation/panel-header-pickers.spec.ts
  • e2e/tests/onboarding/quick-start-tour.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant