Skip to content

Use rmw_event_type_is_supported to skip tests (backport #563) #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 2 commits into from
Mar 12, 2025
+14 −0
Merged

Use rmw_event_type_is_supported to skip tests (backport #563) #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e920462
Use rmw_event_type_is_supported to skip tests (#563)
ahcorde Mar 11, 2025
a86bd0c
Fix merge
ahcorde Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test_quality_of_service/test/test_deadline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ using namespace std::chrono_literals;

/// Test Deadline with a single publishing node and single subscriber node
TEST_F(QosRclcppTestFixture, test_deadline) {
std::string this_rmw_implementation = std::string(rmw_get_implementation_identifier());

if (!rmw_event_type_is_supported(RMW_EVENT_OFFERED_DEADLINE_MISSED) ||
!rmw_event_type_is_supported(RMW_EVENT_REQUESTED_DEADLINE_MISSED))
{
GTEST_SKIP();
}

int expected_number_of_events = 4;
// Bump deadline duration when testing against rmw_connextdds to
// cope with the longer discovery times it entails.
Expand Down
6 changes: 6 additions & 0 deletions test_quality_of_service/test/test_liveliness.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ using namespace std::chrono_literals;

/// Test Automatic Liveliness with a single publishing node and single subscriber node
TEST_F(QosRclcppTestFixture, test_automatic_liveliness_changed) {
if (!rmw_event_type_is_supported(RMW_EVENT_LIVELINESS_CHANGED) ||
!rmw_event_type_is_supported(RMW_EVENT_LIVELINESS_LOST))
{
GTEST_SKIP();
}

const std::chrono::milliseconds max_test_length = 8s;
const std::chrono::milliseconds kill_publisher_after = 2s;
const std::chrono::milliseconds publish_period = 200ms;
Expand Down