Skip to content

introduce ActionEndpointInfo from action graph.#3209

Open
fujitatomoya wants to merge 2 commits into
rollingfrom
ros2cli/issues/1210
Open

introduce ActionEndpointInfo from action graph.#3209
fujitatomoya wants to merge 2 commits into
rollingfrom
ros2cli/issues/1210

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Description

Part of ros2/ros2cli#1210

Fixes # (issue)

Is this user-facing behavior change?

No, new methods and APIs to support ActionEndpointInfo

Did you use Generative AI?

Yes, Claude Fable

Additional Information

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@mergify

mergify Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new action-graph API to rclcpp_action which exposes aggregated endpoint information (goal/cancel/result services + feedback/status topics) via the new ActionEndpointInfo type, plus new graph query/count functions and accompanying tests.

Changes:

  • Introduce rclcpp_action::ActionEndpointInfo and public graph query functions in include/rclcpp_action/graph.hpp.
  • Implement graph queries/counting backed by rcl_action graph APIs in rclcpp_action/src/graph.cpp.
  • Add test_graph coverage and wire the new source/test into rclcpp_action’s CMake build.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rclcpp_action/test/test_graph.cpp Adds unit tests for the new action graph info and counting APIs.
rclcpp_action/src/graph.cpp Implements conversion and retrieval logic for action client/server endpoint info and counts.
rclcpp_action/include/rclcpp_action/rclcpp_action.hpp Exposes the new graph API via the umbrella header.
rclcpp_action/include/rclcpp_action/graph.hpp Declares the new ActionEndpointInfo API and graph query/count functions.
rclcpp_action/CMakeLists.txt Builds/installs the new implementation file and adds the new gtest target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rclcpp_action/src/graph.cpp
Comment thread rclcpp_action/src/graph.cpp
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants