introduce ActionEndpointInfo from action graph.#3209
Open
fujitatomoya wants to merge 2 commits into
Open
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
There was a problem hiding this comment.
Pull request overview
Adds a new action-graph API to rclcpp_action which exposes aggregated endpoint information (goal/cancel/result services + feedback/status topics) via the new ActionEndpointInfo type, plus new graph query/count functions and accompanying tests.
Changes:
- Introduce
rclcpp_action::ActionEndpointInfoand public graph query functions ininclude/rclcpp_action/graph.hpp. - Implement graph queries/counting backed by
rcl_actiongraph APIs inrclcpp_action/src/graph.cpp. - Add
test_graphcoverage and wire the new source/test intorclcpp_action’s CMake build.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rclcpp_action/test/test_graph.cpp | Adds unit tests for the new action graph info and counting APIs. |
| rclcpp_action/src/graph.cpp | Implements conversion and retrieval logic for action client/server endpoint info and counts. |
| rclcpp_action/include/rclcpp_action/rclcpp_action.hpp | Exposes the new graph API via the umbrella header. |
| rclcpp_action/include/rclcpp_action/graph.hpp | Declares the new ActionEndpointInfo API and graph query/count functions. |
| rclcpp_action/CMakeLists.txt | Builds/installs the new implementation file and adds the new gtest target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of ros2/ros2cli#1210
Fixes # (issue)
Is this user-facing behavior change?
No, new methods and APIs to support ActionEndpointInfo
Did you use Generative AI?
Yes, Claude Fable
Additional Information