feat: Added new statistics interface / removed statistics publisher#3203
Open
jmachowinski wants to merge 1 commit into
Open
feat: Added new statistics interface / removed statistics publisher#3203jmachowinski wants to merge 1 commit into
jmachowinski wants to merge 1 commit into
Conversation
This removes the half backed statistics implementation and replaces it with a interface that can be implemented by a third party pkg to archive the same functionality. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Collaborator
Author
|
Pulls: #3203
|
Collaborator
Author
|
This reduced the compile time of a node with 1 sub and 1 publisher from 6.32s to 4.91s on a Ryzen 9900X |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the half backed statistics implementation and replaces it with a interface that can be implemented by a third party pkg to archive the same functionality.
Is this user-facing behavior change?
Yes, we remove an existing feature. Due to recent bug reports I believe almost nobody was using it.
But as states, this also enables community pkgs to replicate the existing behavior.
Did you use Generative AI?
Yes, SWE-1.7