Skip to content

Fix launch_testing_ros so it works with pytest 7.#543

Merged
clalancette merged 1 commit intorollingfrom
clalancette/fix-pytest7
May 6, 2026
Merged

Fix launch_testing_ros so it works with pytest 7.#543
clalancette merged 1 commit intorollingfrom
clalancette/fix-pytest7

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

Description

We need this compatibility because Windows pixi is still using an older pytest. This doesn't really
hurt anything either.

While we are in here, fix a pep257 warning that I noticed in the tests.

Is this user-facing behavior change?

No.

Did you use Generative AI?

Yes, Claude Opus 4.7

Additional Information

This is follow-up to #540

This needs to be backported to Lyrical along with #541

We need this compatibility because Windows pixi is
still using an older pytest.  This doesn't really
hurt anything either.

While we are in here, fix a pep257 warning that I noticed
in the tests.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from mjcarroll May 5, 2026 20:05
@clalancette
Copy link
Copy Markdown
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit 1c0a7ae into rolling May 6, 2026
3 checks passed
@clalancette clalancette deleted the clalancette/fix-pytest7 branch May 6, 2026 00:45
@clalancette
Copy link
Copy Markdown
Contributor Author

@Mergifyio backport lyrical

@mergify
Copy link
Copy Markdown

mergify Bot commented May 6, 2026

backport lyrical

✅ Backports have been created

Details

Cherry-pick of 1c0a7ae has failed:

On branch mergify/bp/lyrical/pr-543
Your branch is up to date with 'origin/lyrical'.

You are currently cherry-picking commit 1c0a7ae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   launch_testing_ros/test/examples/check_msgs_launch_test.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   launch_testing_ros/launch_testing_ros_pytest_entrypoint.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

clalancette added a commit that referenced this pull request May 6, 2026
We need this compatibility because Windows pixi is
still using an older pytest.  This doesn't really
hurt anything either.

While we are in here, fix a pep257 warning that I noticed
in the tests.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit that referenced this pull request May 8, 2026
…) (#541)

* Fix Pytest 8/9 compatibility in launch_testing_ros hooks (#540)

Rename deprecated path argument to module_path to avoid warnings and failures in newer pytest versions.

Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh]

Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
(cherry picked from commit 5ba9fa4)

* Fix launch_testing_ros so it works with pytest 7. (#543)

We need this compatibility because Windows pixi is
still using an older pytest.  This doesn't really
hurt anything either.

While we are in here, fix a pep257 warning that I noticed
in the tests.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

---------

Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants