Fix launch_testing_ros so it works with pytest 7.#543
Merged
clalancette merged 1 commit intorollingfrom May 6, 2026
Merged
Conversation
We need this compatibility because Windows pixi is still using an older pytest. This doesn't really hurt anything either. While we are in here, fix a pep257 warning that I noticed in the tests. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
mjcarroll
approved these changes
May 5, 2026
Contributor
Author
|
@Mergifyio backport lyrical |
✅ Backports have been createdDetails
Cherry-pick of 1c0a7ae has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
clalancette
added a commit
that referenced
this pull request
May 6, 2026
We need this compatibility because Windows pixi is still using an older pytest. This doesn't really hurt anything either. While we are in here, fix a pep257 warning that I noticed in the tests. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
May 8, 2026
…) (#541) * Fix Pytest 8/9 compatibility in launch_testing_ros hooks (#540) Rename deprecated path argument to module_path to avoid warnings and failures in newer pytest versions. Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh] Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> (cherry picked from commit 5ba9fa4) * Fix launch_testing_ros so it works with pytest 7. (#543) We need this compatibility because Windows pixi is still using an older pytest. This doesn't really hurt anything either. While we are in here, fix a pep257 warning that I noticed in the tests. Signed-off-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need this compatibility because Windows pixi is still using an older pytest. This doesn't really
hurt anything either.
While we are in here, fix a pep257 warning that I noticed in the tests.
Is this user-facing behavior change?
No.
Did you use Generative AI?
Yes, Claude Opus 4.7
Additional Information
This is follow-up to #540
This needs to be backported to Lyrical along with #541