Fix Pytest 8/9 compatibility in hooks (backport #972)#973
Open
mergify[bot] wants to merge 2 commits intolyricalfrom
Open
Fix Pytest 8/9 compatibility in hooks (backport #972)#973mergify[bot] wants to merge 2 commits intolyricalfrom
mergify[bot] wants to merge 2 commits intolyricalfrom
Conversation
This commit addresses two issues: 1. Renames deprecated path argument to module_path/collection_path in pytest hooks to support Pytest 8/9. 2. Ensures LaunchService run_async task is always awaited by registering the finalizer earlier and passing the task explicitly. Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh] Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> (cherry picked from commit 0630831)
ahcorde
approved these changes
May 6, 2026
Contributor
|
Pulls: #973, ros2/launch_ros#541
|
Contributor
|
New CI for this is in ros2/launch_ros#541 (comment) |
…974) * Robust Pytest 7/8/9 compatibility and collection fixes Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> * Robust Pytest 7/8/9 compatibility and collection fixes Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> * More fixes (hopefully working this time). Signed-off-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Contributor
|
New CI for this is in ros2/launch_ros#541 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecated hook signatures in launch and launch_testing that cause failures in newer pytest versions (e.g. Pytest 9.0).
This is an automatic backport of pull request #972 done by Mergify.