Skip to content

Fix #931:add 'actions' key support for YAML,keeping the existing 'children' key as a fallback #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SanjayS66 wants to merge 1 commit into
base: rolling
Choose a base branch
from
+9 −5
Open

Fix #931:add 'actions' key support for YAML,keeping the existing 'children' key as a fallback #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions launch_yaml/launch_yaml/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,17 @@ def children(self) -> List['Entity']:
f'\n---\n{self.__element}\n---'
)
if isinstance(self.__element, dict):
if 'children' not in self.__element:
if 'actions' in self.__element:
self.__read_keys.add('actions')
children = self.__element['actions']
elif 'children' in self.__element:
self.__read_keys.add('children')
children = self.__element['children']
else :
raise ValueError(
f'Expected entity `{self.__type_name}` to have children entities.'
f'That can be a list of subentities or a dictionary with a `children` '
'list element')
self.__read_keys.add('children')
children = self.__element['children']
f'That can be a list of subentities or a dictionary with an `actions` '
f'or `children` list element')
else:
children = self.__element
entities = []
Expand Down