Skip to content

Use python_qt_binding#157 and skip shiboken#324

Merged
ahcorde merged 6 commits intoahcorde/rolling/qt6from
sloretz__ahcorde/rolling/qt6
Mar 31, 2026
Merged

Use python_qt_binding#157 and skip shiboken#324
ahcorde merged 6 commits intoahcorde/rolling/qt6from
sloretz__ahcorde/rolling/qt6

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Mar 28, 2026

This updates the branch to use this PR:
ros-visualization/python_qt_binding#157

And it also completely disables shiboken support, since it appears to be broken as packaged in Debian and Ubuntu:

I started to update how qt_gui_cpp used Shiboken, but it looks like it's effectively been skipped for a long time with the if(Shiboken_VERSION VERSION_GREATER "1.1.1") check.

This updates the branch to use this PR:
ros-visualization/python_qt_binding#157

And it also completely disables shiboken support, since it appears to be
broken as packaged in Debian and Ubuntu:

* https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1131536
* https://bugs.launchpad.net/ubuntu/+source/pyside6/+bug/2146611

Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
@sloretz sloretz requested a review from ahcorde March 28, 2026 00:39
@sloretz sloretz self-assigned this Mar 28, 2026
sloretz added 4 commits March 28, 2026 00:48
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
@sloretz sloretz marked this pull request as ready for review March 31, 2026 03:53
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 31, 2026

@ahcorde Would you be willing to look at this PR? It modifies #293 (hence it target's your branch instead of rolling) to use ros-visualization/python_qt_binding#157 , plus it fixes some Qt6 incompatibilities in the about dialog.

@ahcorde ahcorde merged commit 9283fba into ahcorde/rolling/qt6 Mar 31, 2026
1 check was pending
@ahcorde ahcorde deleted the sloretz__ahcorde/rolling/qt6 branch March 31, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants