Use python_qt_binding#157 and skip shiboken#324
Merged
ahcorde merged 6 commits intoahcorde/rolling/qt6from Mar 31, 2026
Merged
Conversation
This updates the branch to use this PR: ros-visualization/python_qt_binding#157 And it also completely disables shiboken support, since it appears to be broken as packaged in Debian and Ubuntu: * https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1131536 * https://bugs.launchpad.net/ubuntu/+source/pyside6/+bug/2146611 Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Contributor
Author
|
@ahcorde Would you be willing to look at this PR? It modifies #293 (hence it target's your branch instead of rolling) to use ros-visualization/python_qt_binding#157 , plus it fixes some Qt6 incompatibilities in the about dialog. |
ahcorde
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the branch to use this PR:
ros-visualization/python_qt_binding#157
And it also completely disables shiboken support, since it appears to be broken as packaged in Debian and Ubuntu:
I started to update how
qt_gui_cppused Shiboken, but it looks like it's effectively been skipped for a long time with theif(Shiboken_VERSION VERSION_GREATER "1.1.1")check.