Fix per-platform Apple token config #38
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
AppleAuth::Tokenclass to make it more flexible and testable by allowing a custom configuration object to be passed in, rather than relying on a global configuration. All internal references to configuration values have been updated to use the instance-specificconfigobject.Configuration injection and usage:
AppleAuth::Tokeninitializer now accepts aconfig:keyword argument, defaulting toAppleAuth.config, and stores it as an instance variable. All internal references to configuration values (such asapple_client_id,apple_team_id,redirect_uri,apple_key_id, andapple_private_key) now use this instance variable instead of the global config. [1] [2] [3] [4] [5]Code improvements:
is_a?, making the code more idiomatic and robust.### SummaryOther Information