Adds redis tags to fix package issue - #1685
Merged
Merged
Conversation
Fixes #1683 Using `--tags redis` would filter the `include_vars` out and not import the PHP version specific vars leading to an undefined variable for `redis_packages_default` etc. This fixes that by adding the `redis` tag (just like `memcached` and `php`) to the common task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1683
Using
--tags rediswould filter theinclude_varsout and not import the PHP version specific vars leading to an undefined variable forredis_packages_defaultetc.This fixes that by adding the
redistag (just likememcachedandphp) to the common task.