Repository navigation
[hist] Scale profile value statistics - #23862
Draft
Elvand-Lie wants to merge 1 commit into
Draft
Elvand-Lie wants to merge 1 commit into
Elvand-Lie wants to merge 1 commit into
Conversation
Flush buffered fills before scaling and scale the cached value moments along with the bin contents. Assisted-by: codex:gpt-6.1-terra Assisted-by: claude-code:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
TProfile::Scale,TProfile2D::Scale, andTProfile3D::Scaleleave the cached statistics of the profiled value unchanged. They also leave buffered fills unscaled.Flush pending fills before scaling and scale the corresponding first and second moments by the factor and its square. Regression tests cover all three profile dimensions and buffered fills.
The four regression tests fail on the base and pass with the fix. The full
test_TProfileexecutable passes (8 tests) on Linux. The full ROOT test suite and other platforms were not run.Checklist:
Codex (gpt-6.1-terra) implemented the fix and the test; Claude Code (claude-opus-5-5) found the bug.