Repository navigation
[tmva][sofie] Add support for the ONNX ArgMax operator - #23830
Merged
Merged
Conversation
Implement ROperator_ArgMax and its ONNX parser, supporting the axis (including negative values), keepdims and select_last_index attributes. The output is always INT64. Add three tests covering the default attributes, keepdims=0 and select_last_index=1 with ties.
Test Results 24 files 24 suites 3d 20h 19m 36s ⏱️ Results for commit 42f3d8c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Adds support for the ONNX
ArgMaxoperator in SOFIE.Changes or fixes:
ROperator_ArgMax: supports theaxis(negative values included),keepdimsandselect_last_indexattributes. Shapes are handled asDim, so parametric dimensions also work.INT64, as required by the ONNX specification, regardless of the input type.ParseArgMaxparser, registered inRModelParser_ONNX.TestCustomModelsFromONNX(default attributes;axis=1, keepdims=0;axis=-1, select_last_index=1with ties). Expected values were cross-checked with onnxruntime.Checklist: