Repository navigation
[6.40] [df] Consider quoted strings in collection size short syntax - #23826
Merged
dpiparo merged 2 commits intoOct 24, 2026
Merged
Conversation
The regex pattern present before was not refined enough to consider the case where the target #varname could happen to be within a quoted string. Improve the regex pattern in ParseRDFExpression and add a more complicated test case in dataframe_interface.cxx Fixes root-project#23790 (cherry picked from commit cb1b496)
Also add a test where the user defines a column of type std::string with a value that could be ambiguous w.r.t. the short syntax for collection sizes. RDataFrame should not substitute the string value in this case, it should be returned as-is to downstream actions. Co-authored-by: muntasir-396 <muntasirmamun396@gmail.com> (cherry picked from commit c4011b2)
root-project-bot
requested review from
martamaja10 and
vepadulano
as code owners
October 24, 2026 09:39
Test Results 23 files 23 suites 3d 16h 46m 48s ⏱️ Results for commit 98a20ff. ♻️ This comment has been updated with latest results. |
dpiparo
merged commit Oct 24, 2026
aef5c81
into
root-project:v6-40-00-patches
73 of 75 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23804, requested by @vepadulano.