Repository navigation
Conversation
DataLoaderImplicitMT.test01_implicit_mt_not_supported enables implicit multi-threading and expects RDataLoader to raise. In a ROOT built with imt=OFF, EnableImplicitMT() does nothing, so IsImplicitMTEnabled() stays false, the RDataFrame has one slot and nothing is raised. The test fails with "RuntimeError not raised" on the imt=Off CI lane (ubuntu22). Skip the test case when "imt" is not among the configured features.
aaronj0
requested review from
guitargeek,
siliataider and
vepadulano
as code owners
October 23, 2026 16:02
Contributor
Author
|
Follow up to 73d351f which is causing a failure on one of my PR (ubuntu22) which also exists on master: https://github.com/root-project/root/actions/runs/39929134079/job/120332764669 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataLoaderImplicitMT.test01_implicit_mt_not_supported enables implicit multi-threading and expects RDataLoader to raise. In a ROOT built with imt=OFF, EnableImplicitMT() does nothing, so IsImplicitMTEnabled() stays false, the RDataFrame has one slot and nothing is raised. The test fails with "RuntimeError not raised" on the imt=Off CI lane (ubuntu22).
Skip the test case when "imt" is not among the configured features.