Repository navigation
Conversation
Force export of the missing std::filesystem symbols, not exposed by MSVCP140.dll Fixes root-project#23664
guitargeek
approved these changes
Oct 23, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks a lot for the fix
bellenot
marked this pull request as draft
October 23, 2026 14:28
Test Results 24 files 24 suites 3d 22h 6m 43s ⏱️ Results for commit 774c917. ♻️ This comment has been updated with latest results. |
bellenot
marked this pull request as ready for review
October 24, 2026 08:59
bellenot
marked this pull request as draft
October 24, 2026 12:27
bellenot
marked this pull request as ready for review
October 25, 2026 08:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force export of the missing std::filesystem symbols, not exposed by MSVCP140.dll
Fixes #23664