Repository navigation
[xroofit] updates from main xRooFit repo, and sort out include order issue for check-headers.sh postinstall test - #23809
Merged
guitargeek merged 2 commits intoOct 25, 2026
Conversation
…check-headers tests
will-cern
requested review from
dpiparo,
guitargeek and
hageboeck
as code owners
October 23, 2026 10:30
Test Results 24 files 24 suites 4d 4h 54m 19s ⏱️ For more details on these failures, see this check. Results for commit c549223. ♻️ This comment has been updated with latest results. |
guitargeek
approved these changes
Oct 25, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the update. CI failures are unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should also address the issue that was attempted to be fixed by #23407
I resolve that issue by declaring the
xRooHypoSpaceclass inside thexRooNLLVar.hheader, which guarantees the base class it uses is defined.