Repository navigation
[qt6web] fix crash during application teardown - #23794
Merged
Merged
Conversation
During application shutdown ROOT libraries can be partially unloaded and therefore deletion of timer object registered in the global lists may cause application crash. Same is true for qt6 Url scheme handler. Therefore when gSystem is nullptr - skip objects cleanup
From 1 to 10 ms, change name to WebGui.Qt6Timer, was not documented before
Was missing in docu
Test Results 24 files 24 suites 4d 4h 32m 21s ⏱️ For more details on these failures, see this check. Results for commit fbf5bf2. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During application shutdown ROOT libraries
can be partially unloaded and therefore
deletion of timer object registered in the global lists may cause application crash.
Same is true for qt6 Url scheme handler.
Therefore when gSystem is nullptr - skip objects cleanup
Reduce default timer period for Qt6 web canvas to 10 ms.
Update documentation.