Repository navigation
[df] Integrate RProfile filling - #23792
Merged
Merged
Conversation
They are only needed for Book().
hahnjo
force-pushed
the
hist-profile-df
branch
from
October 22, 2026 09:18
857c81e to
1d873a8
Compare
vepadulano
approved these changes
Oct 22, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
Thanks! In principle LGTM, just two minor comments from my side.
Test Results 24 files 24 suites 3d 19h 54m 26s ⏱️ Results for commit 47ad179. ♻️ This comment has been updated with latest results. |
Similar to RHist filling, but extracting the value argument that is passed as separate argument to the Fill method.
hahnjo
force-pushed
the
hist-profile-df
branch
from
October 24, 2026 11:38
1d873a8 to
47ad179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
RHistfilling, but extracting the value argument that is passed as separate argument to theFillmethod.